Downgrade #[test] on macro call to warning
#94624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to rust-lang#92959. Address rust-lang#94508.
estebank
added
beta-nominated
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Dylan-DPC |
|
@bors: r+ |
|
📌 Commit 050d589 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 5, 2022
Downgrade `#[test]` on macro call to warning Follow up to rust-lang#92959. Address rust-lang#94508.
This was referenced Mar 5, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 5, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#94446 (UNIX `remove_dir_all()`: Try recursing first on the slow path) - rust-lang#94460 (Reenable generator drop tracking tests and fix mutation handling) - rust-lang#94620 (Edit docs on consistency of `PartialOrd` and `PartialEq`) - rust-lang#94624 (Downgrade `#[test]` on macro call to warning) - rust-lang#94626 (Add known-bug directive to issue rust-lang#47511 test case) - rust-lang#94631 (Fix typo in c-variadic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2022
…ulacrum [beta] backports * Update LLVM submodule rust-lang#94764 * Statically compile libstdc++ everywhere if asked rust-lang#94719 * Downgrade #[test] on macro call to warning rust-lang#94624 * Delay bug in expr adjustment when check_expr is called multiple times rust-lang#94596 * bootstrap: correct reading of flags for llvm rust-lang#94466 * Check method input expressions once rust-lang#94438 * remove feature gate in control_flow examples rust-lang#94283 r? `@Mark-Simulacrum`
JarvisCraft
added a commit
to JarvisCraft/rust
that referenced
this pull request
Oct 2, 2022
This fixes a typo first appearing in rust-lang#94624 in which test-macro diagnostic uses "a" article twice. Since I searched sources for " a a " sequences, I also fixed the same issue in a few source files where I found it. Signed-off-by: Petr Portnov <[email protected]>
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 3, 2022
…r=compiler-errors Fix duplicate usage of `a` article. This fixes a typo first appearing in rust-lang#94624 in which test-macro diagnostic uses "a" article twice. Since I searched the sources for " a a " sequences, I also fixed the same issue in a few files where I found it.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2023
This fixes a typo first appearing in rust-lang#94624 in which test-macro diagnostic uses "a" article twice. Since I searched sources for " a a " sequences, I also fixed the same issue in a few source files where I found it. Signed-off-by: Petr Portnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #92959. Address #94508.