Skip to content

Fix ICE if no trait assoc const eq #93861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fix ICE if no trait assoc const eq #93861

merged 1 commit into from
Feb 11, 2022

Conversation

JulianKnodt
Copy link
Contributor

Fixes #93835

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 10, 2022
@rust-highfive
Copy link
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wesleywiser
Copy link
Member

Actual tidy error

2022-02-10T16:13:15.8632325Z tidy error: /checkout/src/test/ui/associated-consts/issue-93835.rs: leading newline

wesleywiser
wesleywiser reviewed Feb 10, 2022
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
wesleywiser
wesleywiser approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 10, 2022

📌 Commit 6bc28c8 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2022
@bors
Auto merge of rust-lang#93891 - matthiaskrgr:rollup-xadut8w, r=matthi…
78450d2 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#92242 (Erase regions before calculating layout for packed field capture)
 - rust-lang#93443 (Add comment on stable_hash_impl for OwnerNodes)
 - rust-lang#93742 (Drop rustc-docs from complete profile)
 - rust-lang#93852 (rustdoc: remove support for multi-query search)
 - rust-lang#93853 (Make all `hir::Map` methods consistently by-value)
 - rust-lang#93861 (Fix ICE if no trait assoc const eq)
 - rust-lang#93862 (Split x86_64-apple builder into two)
 - rust-lang#93864 (Remove ArchiveBuilder::update_symbols)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a59d312 into rust-lang:master Feb 11, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 11, 2022
@JulianKnodt JulianKnodt deleted the notraitace branch February 12, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

ICE: unwrap None in type_of.rs (associated_const_equality)
6 participants
@JulianKnodt @rust-highfive @rust-log-analyzer @wesleywiser @bors @rustbot