Don't ICE when an extern static is too big for the current architecture #93850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #94174) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me after rebase |
jackh726
added
S-waiting-on-author
asquared31415
force-pushed
the
extern-static-size-ice
branch
from
354a33d to
aaf68bc
Compare
|
Seems to be a CI failure due to crates.io issues, will try later |
asquared31415
force-pushed
the
extern-static-size-ice
branch
from
aaf68bc to
62f741c
Compare
asquared31415
force-pushed
the
extern-static-size-ice
branch
from
62f741c to
75b15c6
Compare
|
@bors r+ |
|
📌 Commit 75b15c6 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 25, 2022
…e, r=jackh726 Don't ICE when an extern static is too big for the current architecture Fixes rust-lang#93760 Emit an error instead of ICEing when an `extern` static's size overflows the allowed maximum for the target. Changes the error message in the existing `delay_span_bug` call to the true layout error, first for debugging purposes, but opted to leave in to potentially assist future developers as it was being reached in unexpected ways already.
This was referenced Feb 25, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#93850 (Don't ICE when an extern static is too big for the current architecture) - rust-lang#94154 (Wire up unstable rustc --check-cfg to rustdoc) - rust-lang#94353 (Fix debug_assert in unused lint pass) - rust-lang#94366 (Add missing item to release notes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93760
Emit an error instead of ICEing when an
externstatic's size overflows the allowed maximum for the target.Changes the error message in the existing
delay_span_bugcall to the true layout error, first for debugging purposes, but opted to leave in to potentially assist future developers as it was being reached in unexpected ways already.