Rollup of 7 pull requests #92593
Closed
Rollup of 7 pull requests #92593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update Node to v16.9.0, es-check to 6.1.1, and eslint to 8.6.0.
This reduces clutter on doc pages.
A missing break statement lead to an infinite loop in bootstrap.py.
…dtwco Some cleanups around check_argument_types Split out in ways from my rebase/continuation of rust-lang#71827 Commits are mostly self-explanatory and these changes should be fairly straightforward
…crum Regression test for borrowck ICE rust-lang#92015 This issue has come up a few times. Creating a regression test. Closes rust-lang#92015.
…imitive-types, r=Manishearth Rustdoc: resolve associated traits for non-generic primitive types Fixes rust-lang#90703 This seems to work: <img width="457" alt="image" src="https://user-images.githubusercontent.com/2807772/147774059-9556ff96-4519-409e-8ed0-c33ecc436171.png"> I'm just afraid I might have missed some cases / broken previous functionality. I also have not written tests yet, I will have to take a look to see where tests are and how they are structured, but any help there is also appreciated.
…Gomez Move crate drop-down to search results page This reduces clutter on doc pages. Part of rust-lang#59840 r? `@GuillaumeGomez` Demo: https://rustdoc.crud.net/jsha/crates-in-results/std/index.html?search=str
Allow unwinding from OOM hooks This is split off from rust-lang#88098 and contains just the bare minimum to allow specifying a custom OOM hook with `set_alloc_error_hook` which unwinds instead of aborting. See rust-lang#88098 for an actual command-line flag which switches the default OOM behavior to unwind instead of aborting. Previous perf results show a negligible impact on performance.
…ant-count, r=the8472 Add note about non_exhaustive to variant_count Since `variant_count` isn't returning something opaque, I thought it makes sense to explicitly call out that its return value may change for some enums. cc rust-lang#73662
…lacrum Break the loop A missing break statement lead to an infinite loop in bootstrap.py. I also added a short sleep so it's not constantly running at 100%. But I can remove that if it's not wanted. Fixes rust-lang#76661
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
|
📌 Commit cc59087 has been approved by |
bors
added
the
S-waiting-on-bors
|
FYI #92589 has been |
|
It was just r+ed again.. ^^ |
|
⌛ Testing commit cc59087 with merge 4cf8b4fb1dd5428878ddb340f2b8328f8cc425bd... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit cc59087 with merge 05b8f377b6258b78c5136bb362fdd60fecfb74c5... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup