Remove &self from PrintState::to_string #92336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit e9fbe79 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2022
…erister Remove &self from PrintState::to_string The point of `PrintState::to_string` is to create a `State` and evaluate the caller's closure on it: https://github.com/rust-lang/rust/blob/e9fbe79292783972a222afd270db3f77c0b4f3c8/compiler/rustc_ast_pretty/src/pprust/state.rs#L868-L872 Making the caller *also* construct and pass in a `State`, which is then ignored, was confusing.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#84640 (Implement `TryFrom<char>` for `u8`) - rust-lang#92336 (Remove &self from PrintState::to_string) - rust-lang#92375 (Consolidate checking for msvc when generating debuginfo) - rust-lang#92568 (Add note about non_exhaustive to variant_count) - rust-lang#92600 (Add some missing `#[must_use]` to some `f{32,64}` operations) - rust-lang#92610 (Create CSS class instead of using inline style for search results) - rust-lang#92632 (Implement stabilization of `#[feature(available_parallelism)]`) - rust-lang#92650 (Fix typo in `StableCrateId` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
dtolnay
removed
the
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of
PrintState::to_stringis to create aStateand evaluate the caller's closure on it:rust/compiler/rustc_ast_pretty/src/pprust/state.rs
Lines 868 to 872 in e9fbe79
Making the caller also construct and pass in a
State, which is then ignored, was confusing.