rustdoc: Write doc-comments directly instead of using FromIterator #92082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FromIterator impl made the code much harder to understand. The types don't make sense until you realize there's a custom FromIterator impl.
jyn514
added
C-cleanup
jyn514
changed the title
|
@bors r+ |
|
📌 Commit 7f383c3 has been approved by |
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 18, 2021
rustdoc: Write doc-comments directly instead of using FromIterator The FromIterator impl made the code much harder to understand. The types don't make sense until you realize there's a custom FromIterator impl. This is the first commit from rust-lang#91305; since `@camelid` wrote it originally I don't feel bad unilaterally approving it. r? `@ghost` `@bors` r+ Note that this will conflict with rust-lang#92078.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91834 (Update browser-ui-test version and improve rustdoc-gui tests readability) - rust-lang#91894 (Remove `in_band_lifetimes` from `rustc_incremental`) - rust-lang#91932 (Add user seed to `-Z randomize-layout`) - rust-lang#91956 (fix(rustc_lint): better detect when parens are necessary) - rust-lang#92020 (Remove P: Unpin bound on impl Stream for Pin) - rust-lang#92063 (docs: fix typo) - rust-lang#92082 (rustdoc: Write doc-comments directly instead of using FromIterator) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FromIterator impl made the code much harder to understand. The types
don't make sense until you realize there's a custom FromIterator impl.
This is the first commit from #91305; since @camelid wrote it originally I don't feel bad unilaterally approving it.
r? @ghost
@bors r+
Note that this will conflict with #92078.