- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Remove in_band_lifetimes from rustc_trait_selection
          #91904
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
SylvanB:remove_in_band_lifetimes_rustc_trait_selection
  
      
      
   
  Dec 16, 2021 
      
    
                
     Merged
            
            
  
    Remove in_band_lifetimes from rustc_trait_selection
  
  #91904
              
                    bors
  merged 1 commit into
  rust-lang:master
from
SylvanB:remove_in_band_lifetimes_rustc_trait_selection
  
      
      
   
  Dec 16, 2021 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. | 
      
        
      
      
  
    21 tasks
  
| @bors r+ | 
| 📌 Commit 1ea756b has been approved by  | 
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 14, 2021 
    
    
      
  
    
      
    
  
…stc_trait_selection, r=petrochenkov Remove `in_band_lifetimes` from `rustc_trait_selection` Another one for rust-lang#91867
  This was referenced Dec 14, 2021 
      
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 14, 2021 
    
    
      
  
    
      
    
  
…stc_trait_selection, r=petrochenkov Remove `in_band_lifetimes` from `rustc_trait_selection` Another one for rust-lang#91867
  This was referenced Dec 14, 2021 
      
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 14, 2021 
    
    
      
  
    
      
    
  
…stc_trait_selection, r=petrochenkov Remove `in_band_lifetimes` from `rustc_trait_selection` Another one for rust-lang#91867
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Dec 14, 2021 
    
    
      
  
    
      
    
  
…stc_trait_selection, r=petrochenkov Remove `in_band_lifetimes` from `rustc_trait_selection` Another one for rust-lang#91867
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
1ea756b    to
    dd5717a      
    Compare
  
    | @rustbot label -S-waiting-on-author +S-waiting-on-review | 
| @bors r+ | 
| 📌 Commit dd5717a has been approved by  | 
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Dec 16, 2021 
    
    
      
  
    
      
    
  
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#91901 (Remove `in_band_lifetimes` from `rustc_symbol_mangling`) - rust-lang#91904 (Remove `in_band_lifetimes` from `rustc_trait_selection`) - rust-lang#91951 (update stdarch) - rust-lang#91958 (Apply rust-logo class only on default logo) - rust-lang#91972 (link to pref_align_of tracking issue) - rust-lang#91986 (Bump compiler-builtins to 0.1.66) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Another one for #91867