Enable svh tests on msvc #91411
Merged
Enable svh tests on msvc #91411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @petrochenkov as one person who reliably reproduced them, it sounds like, at least in the past... But generally I see no problem with trying this out. @bors rollup=iffy |
|
I haven't seen these errors for many years. |
|
📌 Commit a8e1ac9 has been approved by |
bors
added
S-waiting-on-bors
apiraino
added
the
T-compiler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 2, 2021
…askrgr Rollup of 4 iffy pull requests Successful merges: - rust-lang#89234 (Disallow non-c-like but "fieldless" ADTs from being casted to integer if they use arbitrary enum discriminant) - rust-lang#91045 (Issue 90702 fix: Stop treating some crate loading failures as fatal errors) - rust-lang#91394 (Bump stage0 compiler) - rust-lang#91411 (Enable svh tests on msvc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were ignored for msvc in #30778 because of additional notes that were being added for some reason. I'm fairly confident this has been fixed in the intervening years so lets try re-enabling these tests.
Fixes #31306