Add drop_while as doc alias to Iterator::skip_while
#91383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
This seems reasonable to me, and consistent with the doc alias policy. We should make sure this doesn't generate confusing results if people search for @bors r+ |
|
📌 Commit dea3494 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#91243 (Don't treat unnormalized function arguments as well-formed) - rust-lang#91250 (Refactor EmitterWriter::emit_suggestion_default ) - rust-lang#91317 (tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu) - rust-lang#91323 (CTFE: support assert_zero_valid and assert_uninit_valid) - rust-lang#91358 (Fix small typo) - rust-lang#91360 (:arrow_up: rust-analyzer) - rust-lang#91368 (Don't re-export `MirPass`) - rust-lang#91383 (Add `drop_while` as doc alias to `Iterator::skip_while`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_whileis commonly referred to asdrop_whilein other languages (clojure/c++/haskell). This recently came up in Zulip as well.This pull request adds 'drop_while' as a doc-alias for 'skip_while'.
r? @joshtriplett