Skip to content

Revert "Temporarily rename int_roundings functions to avoid conflicts" #91141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2021
Merged

Revert "Temporarily rename int_roundings functions to avoid conflicts" #91141

merged 1 commit into from
Dec 19, 2021

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Nov 22, 2021

This reverts commit 3ece63b.

This should be okay because #90329 has been merged.

r? @joshtriplett

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2021
@joshtriplett
Copy link
Member

@bors try

Let's do a crater run on this.

@bors
Copy link
Collaborator

bors commented Nov 22, 2021

⌛ Trying commit 41f70f3 with merge cac44d9528e3bbbdaa1537d187bd489ccc5de18c...

@bors
Copy link
Collaborator

bors commented Nov 22, 2021

☀️ Try build successful - checks-actions
Build commit: cac44d9528e3bbbdaa1537d187bd489ccc5de18c (cac44d9528e3bbbdaa1537d187bd489ccc5de18c)

@joshtriplett
Copy link
Member

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-91141 created and queued.
🤖 Automatically detected try build cac44d9528e3bbbdaa1537d187bd489ccc5de18c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-91141 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-91141 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@bors
Copy link
Collaborator

bors commented Nov 23, 2021

@jhpratt: 🔑 Insufficient privileges: not in try users

@jhpratt
Copy link
Member Author

jhpratt commented Nov 23, 2021

@craterbot retry

@craterbot
Copy link
Collaborator

🔒 Error: you're not allowed to interact with this bot.

🔑 If you are a member of the Rust team and need access, add yourself to the whitelist.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@the8472
Copy link
Member

the8472 commented Nov 23, 2021

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-91141 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-91141 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Dec 1, 2021
@craterbot
Copy link
Collaborator

🎉 Experiment pr-91141 is completed!
📊 7 regressed and 8 fixed (195198 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 2, 2021
@nbdd0121
Copy link
Member

nbdd0121 commented Dec 4, 2021

Out of 7 regressed crates:

  • 2 failures have #![feature(int_roundings)] enabled but uses extension method (not sure why).
  • 1 failure uses method with unstable_ prefix.
  • 4 seems spurious.

So it should be okay to merge this.

@jhpratt
Copy link
Member Author

jhpratt commented Dec 19, 2021

@joshtriplett I think this fell by the wayside. Should be a simple r+ — it just reverts your earlier commit. Breakage is nearly nonexistent as should be the case.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 19, 2021

📌 Commit 41f70f3 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2021
@bors
Auto merge of rust-lang#92099 - matthiaskrgr:rollup-4gwv67m, r=matthi…
41c3017 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91141 (Revert "Temporarily rename int_roundings functions to avoid conflicts")
 - rust-lang#91984 (Remove `in_band_lifetimes` from `rustc_middle`)
 - rust-lang#92028 (Sync portable-simd to fix libcore build for AVX-512 enabled targets)
 - rust-lang#92042 (Enable `#[thread_local]` for all windows-msvc targets)
 - rust-lang#92071 (Update example code for Vec::splice to change the length)
 - rust-lang#92077 (rustdoc: Remove unused `collapsed` field)
 - rust-lang#92081 (rustdoc: Remove unnecessary `need_backline` function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d26895 into rust-lang:master Dec 19, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 19, 2021
@jhpratt jhpratt deleted the int_roundings branch December 20, 2021 06:40
@joshtriplett joshtriplett mentioned this pull request Feb 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
9 participants
@jhpratt @joshtriplett @bors @craterbot @the8472 @nbdd0121 @apiraino @rust-highfive @rustbot