disable portable SIMD tests in Miri #90909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Nov 14, 2021
run rustdoc with the miri cfg flag This is important to be able to control which doctests run with `cargo miri test`. In particular, this is required for rust-lang/rust#90909 to work as intended.
|
Sorry for breaking Miri! ^^; |
|
📌 Commit 60595f7 has been approved by |
bors
added
S-waiting-on-bors
|
You only broke https://github.com/rust-lang/miri-test-libstd, so it's really not a problem. :) |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Nov 15, 2021
…orkingjubilee disable portable SIMD tests in Miri Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Nov 15, 2021
…orkingjubilee disable portable SIMD tests in Miri Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 15, 2021
…orkingjubilee disable portable SIMD tests in Miri Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#85766 (Stabilize File::options()) - rust-lang#88601 (Implement `Termination` for `Result<Infallible, E>`) - rust-lang#90058 (Stabilize -Z strip as -C strip) - rust-lang#90790 (Fix standard library test with read_link) - rust-lang#90834 (Android is not GNU) - rust-lang#90835 (Rename WASI's `is_character_device` to `is_char_device`.) - rust-lang#90837 (Move some tests to more reasonable directories - 9) - rust-lang#90848 (Remove bigint_helper_methods for *signed* types) - rust-lang#90892 (fix ICE on Miri/CTFE copy of half a pointer) - rust-lang#90909 (disable portable SIMD tests in Miri) Failed merges: - rust-lang#90128 (Stabilize -Z symbol-mangling-version=v0 as -C symbol-mangling-version=v0) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.