- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Fix trait object error code #90771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Fix trait object error code #90771
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon. Please see the contribution instructions for more information. | 
| 📌 Commit fc9624c has been approved by  | 
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Nov 11, 2021 
    
    
      
  
    
      
    
  
…e, r=michaelwoerister Fix trait object error code closes rust-lang#90768 I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
    
  the8472 
      added a commit
        to the8472/rust
      that referenced
      this pull request
    
      Nov 11, 2021 
    
    
      
  
    
      
    
  
…e, r=michaelwoerister Fix trait object error code closes rust-lang#90768 I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
| ⌛ Testing commit fc9624c with merge 3a46dc80a40d34c7169c973c63a7719cd9ee2e67... | 
    
  hellow554 
      added a commit
        to hellow554/rust
      that referenced
      this pull request
    
      Nov 12, 2021 
    
    
      
  
    
      
    
  
…e, r=michaelwoerister Fix trait object error code closes rust-lang#90768 I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
| 💥 Test timed out | 
| @bors retry | 
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Nov 13, 2021 
    
    
      
  
    
      
    
  
…e, r=michaelwoerister Fix trait object error code closes rust-lang#90768 I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Nov 13, 2021 
    
    
      
  
    
      
    
  
…e, r=michaelwoerister Fix trait object error code closes rust-lang#90768 I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Nov 14, 2021 
    
    
      
  
    
      
    
  
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90771 (Fix trait object error code) - rust-lang#90840 (relate lifetime in `TypeOutlives` bounds on drop impls) - rust-lang#90853 (rustdoc: Use an empty Vec instead of Option<Vec>) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
closes #90768
I
grep:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!