Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

calebzulawski and others added 15 commits November 6, 2021 02:08
…yn514

Use computed visibility in rustdoc

This PR changes `librustdoc` to use computed visibility instead of syntactic visibility. It was initially part of rust-lang#88019, but was separated due to concerns that it might cause a regression somewhere we couldn't predict.

r? `@jyn514`
cc `@cjgillot` `@petrochenkov`
… r=workingjubilee

Allow simd_bitmask to return byte arrays

cc `@rust-lang/project-portable-simd` `@workingjubilee`
…less-search-index-data, r=notriddle,camelid

Remove potential useless data for search index

I uncovered this case when working on rust-lang#90726 to debug rust-lang#90385.

Explanations: if we have a full generic, we check if it has generics then we do the following:
 * If it has only one generic, we remove one nested level in order to not keep the "parent" generic (since it has empty name, it's useless after all).
 * Otherwise we add it alongside its generics.

However, I didn't handle the case where a generic had no generics. Meaning that we were adding items with empty names in the search index. So basically useless data in the search index.

r? `@camelid`
…f, r=dtolnay

Fix collections entry API documentation.

I found some documentation that seems out of date.
@rustbot rustbot added the rollup A PR which is a rollup label Nov 10, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Nov 10, 2021

📌 Commit 5f24975 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 10, 2021
@bors
Copy link
Collaborator

bors commented Nov 10, 2021

⌛ Testing commit 5f24975 with merge 82af160...

@bors
Copy link
Collaborator

bors commented Nov 10, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 82af160 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2021
@bors bors merged commit 82af160 into rust-lang:master Nov 10, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 10, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (82af160): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Small improvement in instruction counts (up to -0.2% on incr-unchanged builds of hyper-2)
  • Very large regression in instruction counts (up to 84.9% on full builds of webrender-wrench)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Nov 11, 2021
@matthiaskrgr
Copy link
Member Author

@Mark-Simulacrum could this be caused by #90361 ?
Is there a way to disable it on the benchmark server?

@hkratz
Copy link
Contributor

hkratz commented Nov 17, 2021

Since the perf regressions are in full doc builds they are more likely caused by #88447.

@matthiaskrgr matthiaskrgr deleted the rollup-266apqm branch November 20, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants