Skip to content

Conversation

nbdd0121
Copy link
Member

@nbdd0121 nbdd0121 commented Nov 10, 2021

Temporary fix for #90752.

@rustbot label: +T-compiler +A-mir

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2021
@rustbot rustbot added A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2021
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling unwind v0.0.0 (/checkout/library/unwind)
error[E0493]: destructors cannot be evaluated at compile-time
    --> library/core/src/option.rs:1431:24
     |
1431 |     pub const fn unzip(self) -> (Option<T>, Option<U>) {
     |                        ^^^^ constant functions cannot evaluate destructors
error[E0493]: destructors cannot be evaluated at compile-time
    --> library/core/src/option.rs:1623:28
     |
     |
1623 |     pub const fn transpose(self) -> Result<Option<T>, E> {
     |                            ^^^^ constant functions cannot evaluate destructors
error[E0493]: destructors cannot be evaluated at compile-time
    --> library/core/src/option.rs:2094:26
     |
     |
2094 |     pub const fn flatten(self) -> Option<T> {
     |                          ^^^^ constant functions cannot evaluate destructors
error[E0493]: destructors cannot be evaluated at compile-time
    --> library/core/src/result.rs:1531:28
     |
     |
1531 |     pub const fn transpose(self) -> Option<Result<T, E>> {
     |                            ^^^^ constant functions cannot evaluate destructors
error[E0493]: destructors cannot be evaluated at compile-time
    --> library/core/src/result.rs:1600:33
     |
1600 |     pub const fn into_ok_or_err(self) -> T {

@nbdd0121
Copy link
Member Author

🤔 it seems const_precise_live_drops depends on this, so we couldn't just turn it off.

@nbdd0121
Copy link
Member Author

Closed in favor of a proper fix #90788

@nbdd0121 nbdd0121 closed this Nov 13, 2021
@nbdd0121 nbdd0121 deleted the issue-90752 branch November 13, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants