rustc_llvm: update PassWrapper for recent LLVM #90589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikic (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 50a5ebe has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2021
…ikic rustc_llvm: update PassWrapper for recent LLVM Now AddressSanitizerOptions is a struct, but at least the change was tiny. r? `@nikic`
tmiasko
reviewed
Nov 4, 2021
|
Also, I'm seeing some failures with this applied: Not sure what to make of those, will have to resume digging tomorrow, but if someone sees something please let me know. |
|
It could be https://reviews.llvm.org/D112732, if you already have those changes included. |
|
Hm, that got reverted as https://reviews.llvm.org/D113129, so it's not _that. I'm bisecting now, but I'm pretty sure that this patch is safe, given that I've had clean test runs with this patch applied while bisecting the other breakages. |
|
It re-landed shortly after https://reviews.llvm.org/rGa55c4ec1cee7683d9095327d9d33e7137ec25292 and they will require accompanying changes on rustc side to avoid performing function instrumentation twice. |
|
Aha, I hadn't noticed it had re-landed. Thanks! |
Now AddressSanitizerOptions is a struct, but at least the change was tiny. r? nikic
durin42
force-pushed
the
llvm-14-ASO-now-struct
branch
from
ccb9d0b to
d440ce6
Compare
apiraino
added
the
T-compiler
This happened later in the stream than the other changes, but the fix is overlapping. Fix taken from a55c4ec in LLVM.
|
Hey @nikic I'm sorry but we hit an overlapping fix and had to rebase/add one patch. Can you take a quick look? Things are unchanged other than the last patch in the end. |
|
@bors r+ |
|
📌 Commit d9f2d5f has been approved by |
the8472
added a commit
to the8472/rust
that referenced
this pull request
Nov 11, 2021
…ikic rustc_llvm: update PassWrapper for recent LLVM Now AddressSanitizerOptions is a struct, but at least the change was tiny. r? `@nikic`
|
⌛ Testing commit d9f2d5f with merge 83c0cb760c709fbeecaeed81d70e9f2fb2b0bdf7... |
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90589 (rustc_llvm: update PassWrapper for recent LLVM) - rust-lang#90644 (Extend the const swap feature) - rust-lang#90704 (Unix ExitStatus comments and a tiny docs fix) - rust-lang#90761 (Shorten Span of unused macro lints) - rust-lang#90795 (Add more comments to explain the code to generate the search index) - rust-lang#90798 (Document `unreachable!` custom panic message) - rust-lang#90826 (rustc_feature: Convert `BuiltinAttribute` from tuple to a struct) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now AddressSanitizerOptions is a struct, but at least the change was
tiny.
r? @nikic