fix: inner attribute followed by outer attribute causing ICE

[EliseZeroTwo]

Fixes #87936, #88938, and #89971.

This removes the assertion that validates that there are no outer attributes following inner attributes. Where the inner attribute is invalid you get an actual error.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

[Mark-Simulacrum]

r? @Aaron1011

[Aaron1011]

This will cause incorrectly placed outer attributes to get re-ordered in some cases (e.g. impl Foo { #![inner] #[outer] } would becime #[outer] impl Foo { #![inner] } . Since compilation is going to fail anyway, I think this is reasonable.

@EliseZeroTwo Could you change the assert to a delay_span_bug to make sure that compilation never succeeds with misplaced attributes? Also, could you add a test for one of the closed issues (I can help you with writing it if you want

EDIT: Adding in a delay_span_bug call in that location would actually be pretty difficult. It's fine to just add a test to this PR.

cc @dtolnay - this is somewhat related to #90256

[EliseZeroTwo]

I had attempted to add delay_span_bug but then I ran into a cyclic dependency issue which I think is why you said it would be hard to do?

I added a test for this though, it panics on the commit before mine and runs successfully after my commit.

[Aaron1011]

Thanks!

@bors r+

[bors]

📌 Commit 7f0d43a has been approved by Aaron1011

[bors]

⌛ Testing commit 7f0d43a with merge 4e0d397...