Skip to content

Conversation

winterqt
Copy link
Contributor

rust-lang/backtrace-rs#446 allows binaries built with Nix on macOS to be symbolized.

rust-lang/backtrace-rs#446 allows binaries built
with Nix on macOS to be symbolized.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 18, 2021

📌 Commit 3f87b7c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2021
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#89950 (bootstrap: tweak verbosity settings)
 - rust-lang#89965 (Fix ICE with `let...else` and `ref mut`)
 - rust-lang#89974 (Nicer error message if the user attempts to do let...else if)
 - rust-lang#89987 (Check implementing type for `#[doc(hidden)]`)
 - rust-lang#89989 (rustdoc: Add static size assertion for `clean::Type`)
 - rust-lang#89990 (rustc_span: `Ident::invalid` -> `Ident::empty`)
 - rust-lang#89993 (Remove dead code from `compiletest::json`)
 - rust-lang#89996 (Bump backtrace)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2724b00 into rust-lang:master Oct 18, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 18, 2021
@winterqt winterqt deleted the bump-backtrace branch October 18, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants