-
Couldn't load subscription status.
- Fork 13.9k
Add #[must_use] to remaining alloc functions #89899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
c99f0bb to
7390e53
Compare
This comment has been minimized.
This comment has been minimized.
7390e53 to
7279584
Compare
7279584 to
fb2d0f5
Compare
|
@jkugelman Please do go ahead and add the ones whose only legitimate use for ignoring the return value is leaking memory. (In a separate PR please.) I think it's sufficiently error-prone to call something like |
|
@bors r+ |
|
📌 Commit fb2d0f5 has been approved by |
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#89789 (Add #[must_use] to thread::Builder) - rust-lang#89899 (Add #[must_use] to remaining alloc functions) - rust-lang#90401 (hermit: Implement Condvar::wait_timeout) - rust-lang#90404 (hermitkernel-target: Set OS to "none") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…shtriplett Add #[must_use] to alloc functions that would leak memory As [requested](rust-lang#89899 (comment)) by `@joshtriplett.` > Please do go ahead and add the ones whose only legitimate use for ignoring the return value is leaking memory. (In a separate PR please.) I think it's sufficiently error-prone to call something like alloc and ignore the result that it's legitimate to require `let _ =` for that. I added `realloc` myself. Clippy ignored it because of its `mut` argument. ```rust alloc/src/alloc.rs:123:1 alloc unsafe fn realloc(ptr: *mut u8, layout: Layout, new_size: usize) -> *mut u8; ``` Parent issue: rust-lang#89692 r? `@joshtriplett`
I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is everything remaining from the
alloccrate.I ignored these because they might be used to purposefully leak memory... or other allocator shenanigans? I dunno. I'll add them if y'all tell me to.
I don't know why clippy ignored these. I added them myself:
I added these non-mutating
mutfunctions:I moved a few existing
#[must_use]s from functions onto the iterator types they return:IntoIterSorted,IntoKeys,IntoValues.Parent issue: #89692
r? @joshtriplett