Rollup of 10 pull requests #89838
Closed
Rollup of 10 pull requests #89838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sentence was previously incomplete.
`**node_modules` in a .gitignore is the same than `*node_modules` or `*****node_modules`. It matches every file whose name ends with `node_modules`, including `not_node_modules`. The intent here was obviously to have `**/node_modules` which is the same than just `node_modules`.
add some more testcases resolves rust-lang#52893 resolves rust-lang#68295 resolves rust-lang#87750 resolves rust-lang#88071 All these issues have been fixed according to glacier. Just adding a test so it can be closed. Can anybody tell me why the github keywords do not work? 🤔 Please edit this post if you can fix it.
Edit explanation of test for nested type ascriptions
Fixes typo ("an ascribing") and removes extra.
Closes rust-lang#88233.
Add missing words in `Infallible` docs This sentence was previously incomplete.
Improve CJK font in rustdoc This PR includes: - Fix unicode range of korean letters in `rustdoc.css`. - Add WOFF2 format version of Noto Sans KR font. - Shorten the font file name.
…ions, r=joshtriplett Add #[must_use] to to_value conversions `NonNull<T>::cast` snuck in when I wasn't looking. What a scamp! Parent issue: rust-lang#89692 r? ``@joshtriplett``
…s-typo, r=joshtriplett Fix uppercase/lowercase error Fix rust-lang#89694 (comment) r? ``@joshtriplett``
Fix invalid rules in .gitignore `**node_modules` in a .gitignore is the same than `*node_modules` or `*****node_modules`. It matches every file whose name ends with `node_modules`, including `not_node_modules`. The intent here was obviously to have `**/node_modules` which is the same than just `node_modules`. Reference on git ignoring rules format: https://git-scm.com/docs/gitignore
Add #[inline] to int log10 functions.
Use Option::map_or instead of open coding it ``@rustbot`` modify labels +C-cleanup +T-compiler
…take-two, r=Mark-Simulacrum Fix config.toml overflow-checks options This a follow-up PR to rust-lang#87784. Improvements: * Add missing entries for overflow-checks to config.toml.example. * Add --enable-overflow-checks-std option to configure script. * Make rust.overflow-checks-stdoption default to rust.overflow-checks. Also adds the missing `--enable-debug-assertions-std `option to configure script. r? `@Mark-Simulacrum` cc `@jyn514`
|
@bors r+ p=10 rollup=never |
|
📌 Commit 5b2deeb has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 5b2deeb with merge b11482027b8a2501eba27885dbdf37b209fe100b... |
|
☀️ Test successful - checks-actions |
|
Two hours for a "simple push to master" doesn't seem normal, does it? |
|
Yup, it failed to push, re-creating a new one... |
|
Finished benchmarking commit (b11482027b8a2501eba27885dbdf37b209fe100b): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Infallibledocs #89781 (Add missing words inInfallibledocs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup