Skip to content

Update Clippy #89328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 116 commits into from
Sep 29, 2021
Merged

Update Clippy #89328

merged 116 commits into from
Sep 29, 2021
+2,220 −1,001

Conversation

flip1995
Copy link
Member

Delayed Clippy sync

r? @Manishearth

flip1995 and others added 30 commits July 29, 2021 13:28
@flip1995
Rename two lints to comply with our lint naming convention
c0e0171 
self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain
@bors
Auto merge of rust-lang#7505 - flip1995:beta, r=flip1995
74d1561 
[beta] Backport: Rename two lints to comply with our lint naming convention

self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain

changelog: none

r? `@ghost`
@notriddle
fix(clippy): update loop lints to use arg.span
48268f5 
Adapts clippy for fe1a7f7
@cjgillot
Move the dataflow framework to its own crate.
06ae9e4
@cjgillot
Rename rustc_mir to rustc_const_eval.
98e8682
@flip1995
Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup
091ed44
@camsteffen
Add target to cargo config
7f1c2c0
@camsteffen
Use relative deps path
cea46dd
@camsteffen
Make host libs -L flag optional
2e15c80
@camsteffen
Use relative exe paths
e3b171d
@camsteffen
Use relative path for test builds
ecaf7ac
@camsteffen
Rename test_build_base to test
1074bad
@camsteffen
Remove target dir from aliases
5250744
@camsteffen
Remove special dogfood target
9e08e7f
@bors
Auto merge of rust-lang#88615 - flip1995:clippyup, r=Manishearth
261e34d 
Update Clippy

r? `@Manishearth`
@azdavis
Allow giving reasons for disallowed_methods
293db0d
@Labelray
add new lint iter_not_returning_iterator
8f88acd
@bors
Auto merge of rust-lang#7621 - azdavis:master, r=camsteffen
36e6469 
Allow giving reasons for `disallowed_methods`

Fixes rust-lang#7609.

This permits writing the config for `disallowed-methods` as either a list of strings (like before) or a list of tables, where each table gives the path to the disallowed method and an optional reason for why the method is disallowed.

changelog: Allow giving reasons for [`disallowed_methods`]
@bors
Auto merge of rust-lang#7610 - Labelray:master, r=camsteffen
1a52478 
Add new lint `iter_not_returning_iterator`

Add new lint [`iter_not_returning_iterator`] to detect method `iter()` or `iter_mut()` returning a type not implementing `Iterator`
changelog: Add new lint [`iter_not_returning_iterator`]
@smoelius
Prep for upgrade to cargo_metadata 0.14.0
ccc087e
@smoelius
Update dependencies
43ed206
@flip1995
Merge remote-tracking branch 'upstream/beta' into backport_remerge
f402ede
@bors
Auto merge of rust-lang#7649 - flip1995:backport_remerge, r=flip1995
d5595e5 
Backport remerge

This is to keep the backported commit in the repository before force pushing the new beta branch.

r? `@ghost`

changelog: none
(literally none)
@FabianWolff
Ignore automatically derived impls of Clone and Debug in dead cod…
81ce2fb 
…e analysis
@camsteffen
Fix redundant closure bugs
5782dc0
@camsteffen
Eat dogfood
ae2a95f
@HKalbasi
fix derivable impl false positives
5aff720
@bors
Auto merge of rust-lang#7660 - HKalbasi:derivable-impls, r=camsteffen
e8cd4e5 
Fix derivable impl false positives

fix rust-lang#7654
fix rust-lang#7655

changelog: none (not released)
@Jarcho
Fix result order for manual_split_once when rsplitn is used
4c1b6a2
@cjgillot
Keep a parent LocalDefId in SpanData.
11e2966
@rust-highfive
Copy link
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Manishearth
Copy link
Member

@bors r+ p=1

we've got some CI flakiness in GHA but let's see how this goes

@bors
Copy link
Collaborator

bors commented Sep 28, 2021

📌 Commit d0fb9db has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2021
@camsteffen
Copy link
Contributor

Reopen the PR?

@Manishearth
Copy link
Member

eh, we can just wait for bors to run full tests.

@bors
Copy link
Collaborator

bors commented Sep 28, 2021

⌛ Testing commit d0fb9db with merge c082958a881380b02c2f322e66cbdd10d7435f0b...

@bors
Copy link
Collaborator

bors commented Sep 29, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@flip1995
Copy link
Member Author

dist-aarch64-apple seems to have timed out. (run build is still going, at least if you can trust the GHA UI)

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2021
@bors
Copy link
Collaborator

bors commented Sep 29, 2021

⌛ Testing commit d0fb9db with merge 6f608ce...

@bors
Copy link
Collaborator

bors commented Sep 29, 2021

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 6f608ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2021
@bors bors merged commit 6f608ce into rust-lang:master Sep 29, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 29, 2021
@bors bors mentioned this pull request Sep 29, 2021
Merged
@flip1995 flip1995 deleted the clippyup branch September 29, 2021 11:06
This was referenced Sep 29, 2021
Merged
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6f608ce): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.