Skip to content

Change the order of imports suggestions #89224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2021
Merged

Change the order of imports suggestions #89224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
353d637
change the order of path suggestions
TaKO8Ki Sep 24, 2021
4c23905
use `drain_filter` instead of `filter` and `retain`
TaKO8Ki Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compiler/rustc_resolve/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,6 +1707,12 @@ crate fn show_candidates(
candidates.iter().map(|c| path_names_to_string(&c.path)).collect();

path_strings.sort();
let core_path_strings =
path_strings.iter().filter(|p| p.starts_with("core::")).cloned().collect::<Vec<String>>();
if !core_path_strings.is_empty() {
path_strings.retain(|p| !p.starts_with("core::"));
}
path_strings.extend(core_path_strings);
path_strings.dedup();

let (determiner, kind) = if candidates.len() == 1 {
Expand Down