Skip to content

Improve size_hint bounds for DecodeUtf16 iterator #88763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve size_hint bounds for DecodeUtf16 iterator #88763

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea5cd1
Improve `size_hint` lower bound for `DecodeUtf16` iterator
steffahn Sep 8, 2021
fa5e283
Add comments, and fix issue 88762
steffahn Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion library/core/src/char/decode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,12 @@ impl<I: Iterator<Item = u16>> Iterator for DecodeUtf16<I> {
let (low, high) = self.iter.size_hint();
// we could be entirely valid surrogates (2 elements per
// char), or entirely non-surrogates (1 element per char)
(low / 2, high)
//
// In addition to `self.iter`, there's potentially one
// additional number in `self.buf`.
// On odd lower bound, at least one element must stay unpaired
// (with other elements from `self.iter`).
(low.div_ceil(2), try { high?.checked_add(1)? })
}
}

Expand Down