Skip to content

Conversation

notriddle
Copy link
Contributor

Fixes #88519

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2021
@bors
Copy link
Collaborator

bors commented Sep 1, 2021

☔ The latest upstream changes (presumably #87688) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle notriddle force-pushed the notriddle/is-expr-delims-necessary branch from c7809a6 to 59b245e Compare September 1, 2021 05:02
@michaelwoerister
Copy link
Member

r? @rust-lang/wg-diagnostics

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidtwco
Copy link
Member

r? @davidtwco
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 1, 2021

📌 Commit 59b245e has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 1, 2021
…necessary, r=davidtwco

fix(rustc_lint): better detect when parens are necessary

Fixes rust-lang#88519
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 1, 2021
…necessary, r=davidtwco

fix(rustc_lint): better detect when parens are necessary

Fixes rust-lang#88519
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 2, 2021
…necessary, r=davidtwco

fix(rustc_lint): better detect when parens are necessary

Fixes rust-lang#88519
@bors
Copy link
Collaborator

bors commented Sep 4, 2021

⌛ Testing commit 59b245e with merge 72a51c3...

@bors
Copy link
Collaborator

bors commented Sep 4, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 72a51c3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2021
@bors bors merged commit 72a51c3 into rust-lang:master Sep 4, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 4, 2021
@notriddle notriddle deleted the notriddle/is-expr-delims-necessary branch September 4, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused_parens false positive on cast with match expression
6 participants