Suggest deriving traits if possible #86943
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @estebank for review or re-assignment |
|
☔ The latest upstream changes (presumably #85263) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks for the great suggestions! |
JohnCSimon
added
S-waiting-on-review
inquisitivecrystal
added
the
T-compiler
|
@bors r+ |
|
📌 Commit d552e65e2a4e065cf98ac4703c3833f90ab5d6b3 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d552e65e2a4e065cf98ac4703c3833f90ab5d6b3 with merge b3d10b04488f013cd3ea7d01a6a3de215883a68e... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
| if let ty::PredicateKind::Trait(trait_pred, _) = pred.kind().skip_binder() { | ||
| let trait_ref = trait_pred.trait_ref; | ||
| let self_ty = trait_ref.self_ty(); | ||
| if let ty::Adt(adt_def, _) = self_ty.kind() { | ||
| if adt_def.did.is_local() { | ||
| let diagnostic_items = | ||
| self.tcx.diagnostic_items(trait_ref.def_id.krate); | ||
| return derivables.iter().find_map(|trait_derivable| { | ||
| if let Some(item_def_id) = diagnostic_items.get(trait_derivable) { | ||
| if item_def_id == &trait_ref.def_id | ||
| && !(adt_def.is_enum() && *trait_derivable == sym::Default) | ||
| { | ||
| return Some(( | ||
| format!("{}", self_ty), | ||
| self.tcx.def_span(adt_def.did), | ||
| format!("{}", trait_ref.print_only_trait_path()), | ||
| )); | ||
| } | ||
| } | ||
| None | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| None |
There was a problem hiding this comment.
This has quite a bit of rightwards drift. Could we instead use let x = if let ... else { return; } to early return the closure and make the contents look more linear?
This only applies to builtin derives as I don't think there is a clean way to get the available derives in typeck. Closes rust-lang#85851
ptrojahn
force-pushed
the
suggest_derive
branch
from
d552e65 to
50e5f90
Compare
|
@bors r+ |
|
📌 Commit 50e5f90 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (434cb43): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This only applies to builtin derives as I don't think there is a
clean way to get the available derives in typeck.
Closes #85851