Skip to content

Improve error for missing -Z with debugging option #86680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2021
Merged

Improve error for missing -Z with debugging option #86680

merged 1 commit into from
Jul 1, 2021

Conversation

camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Jun 27, 2021 •
edited
Loading

Before:

❯ rustc --unpretty=hir
error: Unrecognized option: 'unpretty'

After:

❯ rustc --unpretty=hir
error: Unrecognized option: 'unpretty'. Did you mean `-Z unpretty`?

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2021
@petrochenkov
Copy link
Contributor

We also have -C foo options (CG_OPTIONS), they can be searched for candidates as well.

petrochenkov
petrochenkov reviewed Jun 30, 2021
View reviewed changes
@petrochenkov
Copy link
Contributor

Could you also add a test for this? (For some misspelled both -C and -Z options.)

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camsteffen
Copy link
Contributor Author

camsteffen commented Jun 30, 2021 •
edited
Loading

@bors -S-waiting-on-author +S-waiting-on-review

Edit: My apologies, @bors, wrong bot.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 30, 2021

📌 Commit 2a60f09 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2021
@JohnTitor JohnTitor mentioned this pull request Jun 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2021
@bors
Auto merge of rust-lang#86757 - JohnTitor:rollup-acevhz7, r=JohnTitor
866335b 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85504 (the foundation owns rust trademarks)
 - rust-lang#85520 (Fix typo and improve documentation for E0632)
 - rust-lang#86680 (Improve error for missing -Z with debugging option)
 - rust-lang#86728 (Check node kind to avoid ICE in `check_expr_return()`)
 - rust-lang#86740 (copy rust-lld as ld in dist)
 - rust-lang#86746 (Fix rustdoc query type filter)
 - rust-lang#86750 (Test cross-crate usage of `feature(const_trait_impl)`)
 - rust-lang#86755 (alloc: `RawVec<T, A>::shrink` can be in `no_global_oom_handling`.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 56ddef8 into rust-lang:master Jul 1, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 1, 2021
@camsteffen camsteffen deleted the dbg-opt-error branch July 1, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camsteffen @rust-highfive @petrochenkov @rust-log-analyzer @bors @rustbot