- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Fix deny(invalid_doc_attributes)
          #85501
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) | 
              
                    jyn514
  
              
              commented
              
                  
                    May 20, 2021 
                  
              
              
            
            
669d950    to
    9985504      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Does this fix it for it being implicitly denied via  | 
| 
 Yes, I've now added a test case for that (as part of  | 
| @bors r+ | 
| 📌 Commit 261f643 has been approved by  | 
    
  Dylan-DPC-zz 
      pushed a commit
        to Dylan-DPC-zz/rust
      that referenced
      this pull request
    
      Jun 5, 2021 
    
    
      
  
    
      
    
  
Fix `deny(invalid_doc_attributes)` Fixes rust-lang#85497.
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Jun 5, 2021 
    
    
      
  
    
      
    
  
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#83646 (Add a map method to Bound) - rust-lang#85501 (Fix `deny(invalid_doc_attributes)`) - rust-lang#85503 (rustdoc: add tooltips to some buttons) - rust-lang#85710 (Document `From` impls in path.rs) - rust-lang#85760 (Possible errors when accessing file metadata are platform specific) - rust-lang#85974 (td align attribute) - rust-lang#86014 (msp430 linker does not accept -znoexecstack. Set linker_is_gnu to fal…) Failed merges: - rust-lang#85972 (Rustdoc html fixes) r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-lints
  Area: Lints (warnings about flaws in source code) such as unused_mut. 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-rustdoc
  Relevant to the rustdoc team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #85497.