Skip to content

Conversation

tspiteri
Copy link
Contributor

This keeps Wrapping synchronized with the primitives it wraps as for the #32463 wrapping_int_impl feature.

@rust-highfive
Copy link
Contributor

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2021
@tspiteri tspiteri force-pushed the wrapping-bits branch 2 times, most recently from ecafec6 to 8aa33ef Compare May 11, 2021 11:35
This keeps `Wrapping` synchronized with the primitives it wraps as for
the rust-lang#32463 `wrapping_int_impl` feature.
@joshtriplett
Copy link
Member

Seems reasonable to me, and it's unstable with an appropriate tracking issue.

@bors r+

@bors
Copy link
Collaborator

bors commented May 12, 2021

📌 Commit a381e29 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 13, 2021
…laumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#85068 (Fix diagnostic for cross crate private tuple struct constructors)
 - rust-lang#85175 (Rustdoc cleanup)
 - rust-lang#85177 (add BITS associated constant to core::num::Wrapping)
 - rust-lang#85240 (Don't suggest adding `'static` lifetime to arguments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 16c8254 into rust-lang:master May 13, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 13, 2021
@tspiteri tspiteri deleted the wrapping-bits branch May 20, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants