Skip to content

Conversation

jackh726
Copy link
Member

Fixes #83737
Fixes #84604

I can rename HAS_RE_LATE_BOUND, to something like HAS_LATE_BOUND_VARS.

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2021
@jackh726 jackh726 added the WG-traits [RETIRED] Working group: Traits label Apr 28, 2021
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment

@jackh726
Copy link
Member Author

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Apr 28, 2021

📌 Commit c9fbaa6 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
Add HAS_RE_LATE_BOUND if there are bound vars

Fixes rust-lang#83737
Fixes rust-lang#84604

I can rename `HAS_RE_LATE_BOUND`, to something like `HAS_LATE_BOUND_VARS`.

r? `@nikomatsakis`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
Add HAS_RE_LATE_BOUND if there are bound vars

Fixes rust-lang#83737
Fixes rust-lang#84604

I can rename `HAS_RE_LATE_BOUND`, to something like `HAS_LATE_BOUND_VARS`.

r? ``@nikomatsakis``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
Add HAS_RE_LATE_BOUND if there are bound vars

Fixes rust-lang#83737
Fixes rust-lang#84604

I can rename `HAS_RE_LATE_BOUND`, to something like `HAS_LATE_BOUND_VARS`.

r? ```@nikomatsakis```
@richkadel

This comment has been minimized.

@richkadel
Copy link
Contributor

@jackh726 - Thanks for clarifying for me that the bug I pasted above only occurs with debug = true, and this PR still does fix the highlighted issues in the description, as long as debug is NOT enabled. And that you have a follow-up PR to fix the known issue with debug enabled (PR #84682). Thank you!

I'm going to hide my previous comment with the large stack trace.

@jackh726
Copy link
Member Author

Closing in favor of #84682

@jackh726 jackh726 closed this Apr 29, 2021
@jackh726 jackh726 deleted the erase-flags branch March 12, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. WG-traits [RETIRED] Working group: Traits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate symbol error when building with -Zinstrument-coverage rustc panic after merge of PR #76814 (refactor Binder)
5 participants