Rollup of 8 pull requests #83964
Merged
Rollup of 8 pull requests #83964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ou-se Add strong_count mutation methods to Rc The corresponding methods were stabilized on `Arc` in rust-lang#79285 (tracking: rust-lang#71983). This patch implements and stabilizes identical methods on the `Rc` types as well.
Do not emit the advanced diagnostics on macros Fixes rust-lang#83510
…cros, r=varkor Trigger `unused_doc_comments` on macros at once Fixes rust-lang#83768
Use AnonConst for asm! constants This replaces the old system which used explicit promotion. See rust-lang#83169 for more background. The syntax for `const` operands is still the same as before: `const <expr>`. Fixes rust-lang#83169 Because the implementation is heavily based on inline consts, we suffer from the same issues: - We lose the ability to use expressions derived from generics. See the deleted tests in `src/test/ui/asm/const.rs`. - We are hitting the same ICEs as inline consts, for example rust-lang#78174. It is unlikely that we will be able to stabilize this before inline consts are stabilized.
… r=varkor forbid `impl Trait` in generic param defaults Fixes rust-lang#83929 Forbid using `impl Trait` in the default types of generic parameters, e.g. `struct Foo<T = impl Trait>`. I assume this was never supposed to be allowed - it seems no UI test used it. Note that using `impl Trait` in this position did not hit a feature gate error; however, this *shouldn't* be a breaking change as any attempt to use it should have hit the ICE in rust-lang#83929 and/or failed to provide a defining use of the `impl Trait`.
…ascii, r=Manishearth Disable using non-ascii identifiers in extern blocks. Fixes rust-lang#83923.
Add suggestion to reborrow mutable references when they're moved in a for loop Address rust-lang#83924
Do not ICE when closure is involved in Trait Alias Impl Trait Fix rust-lang#83613.
|
@bors r+ rollup=never p=5 |
|
📌 Commit d82419b has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit d82419b with merge d1730234b5256adb03e7c80101db720b7f505943... |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
unused_doc_commentson macros at once #83816 (Triggerunused_doc_commentson macros at once)impl Traitin generic param defaults #83935 (forbidimpl Traitin generic param defaults)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup