- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Fix a couple resolve bugs from binder refactor #83944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) | 
c94310e    to
    782da33      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
782da33    to
    f0c3607      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
f0c3607    to
    3ae5fed      
    Compare
  
    | this looks good to me gj and congrats on merging the binder refactor pr ❤️ incredible work @bors r+ | 
| 📌 Commit 3ae5fed has been approved by  | 
| while we're here, the comment for that function: rust/compiler/rustc_resolve/src/late/lifetimes.rs Line 2641 in 3ae5fed 
 why does that return  | 
| 
 Oops, the second  | 
Rollup of 4 pull requests Successful merges: - rust-lang#83337 (rustdoc: Hide item contents, not items) - rust-lang#83944 (Fix a couple resolve bugs from binder refactor) - rust-lang#84145 (Address comments for vecdeque_binary_search rust-lang#78021) - rust-lang#84172 (Compiler error messages: reduce assertiveness of message E0384) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…omatsakis Followup to rust-lang#83944 Some cleanups requested by `@nikomatsakis` r? `@nikomatsakis`
…omatsakis Followup to rust-lang#83944 Some cleanups requested by ``@nikomatsakis`` r? ``@nikomatsakis``
Rollup of 7 pull requests Successful merges: - rust-lang#84343 (Remove `ScopeTree::closure_tree`) - rust-lang#84376 (Uses flex to fix formatting of h1 at any width) - rust-lang#84377 (Followup to rust-lang#83944) - rust-lang#84396 (Update LLVM submodule) - rust-lang#84402 (Move `sys_common::rwlock::StaticRWLock` etc. to `sys::unix::rwlock`) - rust-lang#84404 (Check for intrinsics before coercing to a function pointer) - rust-lang#84413 (Remove `sys::args::Args::inner_debug` and use `Debug` instead) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #83753
Fixes #83907