Skip to content

Conversation

camelid
Copy link
Member

@camelid camelid commented Mar 25, 2021

No description provided.

@camelid camelid added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Mar 25, 2021
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2021
@camelid camelid force-pushed the split-debuginfo-docs-cleanup branch from 77037cf to 5691fdd Compare April 8, 2021 01:08
@camelid camelid force-pushed the split-debuginfo-docs-cleanup branch from 5691fdd to 8527a15 Compare April 8, 2021 01:09
contain debug information.

Note that `packed` and `unpacked` gated behind `-Zunstable-options` on
Note that `packed` and `unpacked` are gated behind `-Z unstable-options` on
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a space after -Z to make it easier to read. I think we use the with-space style elsewhere as well.

@steveklabnik
Copy link
Contributor

Looks great, thank you!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 8, 2021

📌 Commit 8527a15 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2021
@bors
Copy link
Collaborator

bors commented Apr 8, 2021

⌛ Testing commit 8527a15 with merge 010c236...

@bors
Copy link
Collaborator

bors commented Apr 8, 2021

☀️ Test successful - checks-actions
Approved by: steveklabnik
Pushing 010c236 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2021
@bors bors merged commit 010c236 into rust-lang:master Apr 8, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 8, 2021
@camelid camelid deleted the split-debuginfo-docs-cleanup branch April 8, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants