Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

There are two issues fixed here:

  1. The position of "{version}" and "[src]" spans.
  2. The position of attributes (on top of functions)

Please note that these issues only happen if you have disabled javascript.

Before:

Screenshot from 2021-03-09 20-45-54

After:

Screenshot from 2021-03-09 21-01-32

In the last commit, I added a test to enforce the attributes position. I need to think how to enforce it for the spans but that can comes later on.

r? @Nemo157

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Mar 9, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the fix-nojs-style-issues branch from 3f40da5 to 40adb9a Compare March 9, 2021 20:40
@Nemo157
Copy link
Contributor

Nemo157 commented Mar 11, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 11, 2021

📌 Commit 40adb9a has been approved by Nemo157

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2021
@bors
Copy link
Collaborator

bors commented Mar 11, 2021

⌛ Testing commit 40adb9a with merge ea16128...

@bors
Copy link
Collaborator

bors commented Mar 11, 2021

☀️ Test successful - checks-actions
Approved by: Nemo157
Pushing ea16128 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 11, 2021
@bors bors merged commit ea16128 into rust-lang:master Mar 11, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 11, 2021
@GuillaumeGomez GuillaumeGomez deleted the fix-nojs-style-issues branch March 11, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants