Skip to content

Conversation

@the8472
Copy link
Member

@the8472 the8472 commented Feb 14, 2021

Similar to #82047 except that it only applies in CI but catches more instances of the affected IO patterns.

The expected performance benefit is fairly small, at most a second per minute of compile time, so if it's too much for such a small win feel free to close it.

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2021
@kennytm kennytm added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Feb 14, 2021
@kennytm
Copy link
Member

kennytm commented Feb 14, 2021

For comparison the x86_64-gnu-llvm-9 builder in this PR takes 39m to run, while its base https://github.com/rust-lang/rust/runs/1888745546 takes 37m. Any advantages brought by the remount is likely overwhelmed by the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants