Skip to content

BTreeMap: expose new_internal function and sanitize from_new_internal #81083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2021
Merged

BTreeMap: expose new_internal function and sanitize from_new_internal #81083

merged 1 commit into from
Jan 17, 2021

Conversation

@ssomers
Copy link
Contributor

@ssomers ssomers commented Jan 16, 2021 •
edited
Loading

new_internal is the functional core of the imperative push_internal_level, and from_new_internal can easily do a proper job instead of returning a half-baked node.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jan 16, 2021

📌 Commit d199c5b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2021
@bors
Copy link
Collaborator

bors commented Jan 17, 2021

⌛ Testing commit d199c5b with merge d51cf96...

@bors
Copy link
Collaborator

bors commented Jan 17, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d51cf96 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2021
@bors bors merged commit d51cf96 into rust-lang:master Jan 17, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 17, 2021
@bors bors mentioned this pull request Jan 17, 2021
Closed
@ssomers ssomers deleted the btree_drainy_refactor_1 branch January 17, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ssomers @Mark-Simulacrum @bors @rust-highfive @rustbot