Skip to content

don't redundantly repeat field names #80487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

don't redundantly repeat field names #80487

merged 1 commit into from
Dec 30, 2020

Conversation

@matthiaskrgr
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2020
@jyn514
Copy link
Member

jyn514 commented Dec 29, 2020

@bors delegate=matthiaskrgr

@bors
Copy link
Collaborator

bors commented Dec 29, 2020

✌️ @matthiaskrgr can now approve this pull request

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
skip untracked path cpu-usage.csv during rustfmt invocations
skip untracked path src/doc/book/ during rustfmt invocations
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_middle/src/hir/place.rs"` failed.
Diff in /checkout/compiler/rustc_middle/src/hir/place.rs at line 110:
         base: PlaceBase,
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
         projections: Vec<Projection<'tcx>>,
     ) -> PlaceWithHirId<'tcx> {
-        PlaceWithHirId {
-            hir_id,
-            place: Place { base_ty, base, projections },
-        }
+        PlaceWithHirId { hir_id, place: Place { base_ty, base, projections } }
 }
 
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 src/tools/tidy
Build completed unsuccessfully in 0:00:18

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2020
@matthiaskrgr
Copy link
Member Author

@bors r=jyn514 rollup

@bors
Copy link
Collaborator

bors commented Dec 29, 2020

📌 Commit 0c3af22 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2020
@JohnTitor JohnTitor mentioned this pull request Dec 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2020
@bors
Auto merge of rust-lang#80503 - JohnTitor:rollup-b26vglu, r=JohnTitor
d107a87 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#79812 (Lint on redundant trailing semicolon after item)
 - rust-lang#80348 (remove redundant clones (clippy::redundant_clone))
 - rust-lang#80358 (Edit rustc_span documentation)
 - rust-lang#80457 (Add missing commas to `rustc_ast_pretty::pp` docs)
 - rust-lang#80461 (Add llvm-libunwind change to bootstrap CHANGELOG)
 - rust-lang#80464 (Use Option::map_or instead of open coding it)
 - rust-lang#80465 (Fix typo in ffi-pure.md)
 - rust-lang#80467 (More uses of the matches! macro)
 - rust-lang#80469 (Fix small typo in time comment)
 - rust-lang#80472 (Use sans-serif font for the "all items" page links)
 - rust-lang#80477 (Make forget intrinsic safe)
 - rust-lang#80482 (don't clone copy types)
 - rust-lang#80487 (don't redundantly repeat field names)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3812909 into rust-lang:master Dec 30, 2020
@rustbot rustbot added this to the 1.51.0 milestone Dec 30, 2020
@matthiaskrgr matthiaskrgr deleted the field_names branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

7 participants

@matthiaskrgr @jyn514 @bors @rust-log-analyzer @rust-highfive @Dylan-DPC-zz @rustbot