Skip to content

Fix exhaustiveness in case a byte string literal is used at slice type #79072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix exhaustiveness in case a byte string literal is used at slice type #79072

merged 1 commit into from
Nov 17, 2020

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 15, 2020

fixes #79048

@oli-obk oli-obk added beta-nominated Nominated for backporting to the compiler in the beta channel. A-patterns Relating to patterns and pattern matching labels Nov 15, 2020
@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2020
Nadrieril
Nadrieril reviewed Nov 15, 2020
View reviewed changes
estebank
estebank approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nitpicks addressed or not

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 17, 2020

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Nov 17, 2020

📌 Commit a1cdf72 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2020
@m-ou-se m-ou-se mentioned this pull request Nov 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2020
@bors
Auto merge of rust-lang#79138 - m-ou-se:rollup-owel5ld, r=m-ou-se
c919f49 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#74293 (Rustdoc test compiler output color)
 - rust-lang#78702 ([self-profiling] Include the estimated size of each cgu in the profile)
 - rust-lang#79069 (Get rid of `highlight::Class::None`)
 - rust-lang#79072 (Fix exhaustiveness in case a byte string literal is used at slice type)
 - rust-lang#79120 (update rustfmt to v1.4.27)
 - rust-lang#79125 (Get rid of clean::{Method, TyMethod})
 - rust-lang#79126 (Remove duplicate `Trait::auto` field)
 - rust-lang#79130 (extend macro braces test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b6f5241 into rust-lang:master Nov 17, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 17, 2020
@jyn514 jyn514 mentioned this pull request Nov 28, 2020
Closed
@spastorino
Copy link
Member

Adding T-compiler label so this can be picked up by our automated prioritization tool and added to the following T-compiler weekly meeting agenda.

@spastorino spastorino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 3, 2020
@oli-obk oli-obk deleted the byte_str_pat branch December 4, 2020 07:22
@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 10, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 10, 2020
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.50.0, 1.49.0 Dec 10, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Dec 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2020
@bors
Auto merge of rust-lang#79903 - Mark-Simulacrum:beta-next, r=Mark-Sim…
877c7cb 
…ulacrum

[beta] backports

* Revert rust-lang#77534 fixing rust-lang#77713 on beta, principled fix landed on master
* fix soundness issue in `make_contiguous` rust-lang#79814
* Fix exhaustiveness in case a byte string literal is used at slice type rust-lang#79072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadrieril Nadrieril Nadrieril left review comments

@estebank estebank estebank approved these changes

Assignees

@estebank estebank

Labels
A-patterns Relating to patterns and pattern matching beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

Incorrect "unreachable pattern" warning on nightly
8 participants
@oli-obk @rust-highfive @bors @spastorino @estebank @Nadrieril @Mark-Simulacrum @rustbot