- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Add const generics tests for supertraits + dyn traits. #78478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 3 commits into
  rust-lang:master
from
hameerabbasi:const-generics-supertraits
  
      
      
   
  Oct 29, 2020 
      
    
                
     Merged
            
            Add const generics tests for supertraits + dyn traits. #78478
                    bors
  merged 3 commits into
  rust-lang:master
from
hameerabbasi:const-generics-supertraits
  
      
      
   
  Oct 29, 2020 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
          
 (rust_highfive has picked a reviewer for you, use r? to override)  | 
    
| 
           r? @lcnr  | 
    
      
        
      
      
  
    8 tasks
  
| 
           This is already looking good, a few more cases to consider might be: fn generic<T: Bok<N>, const N: usize>(v: T) {
    fn_taking_taking_dyn_foo::<N>(&v);
}
fn concrete<T: ?Sized + Foo<3>>(_: &T) {}
fn call_super_concrete(x: &dyn Bar<3>) {
    concrete(x);
}Also, it would be great to change this test to    | 
    
              
                    lcnr
  
              
              reviewed
              
                  
                    Oct 28, 2020 
                  
              
              
            
            
              
                    lcnr
  
              
              reviewed
              
                  
                    Oct 28, 2020 
                  
              
              
            
            
| 
           👍 @bors r+ rollup  | 
    
| 
           📌 Commit 22060fa has been approved by   | 
    
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Oct 29, 2020 
    
    
      
  
    
      
    
  
Rollup of 11 pull requests Successful merges: - rust-lang#77213 (rustdoc options to set default theme (and other settings)) - rust-lang#78224 (min_const_generics: allow ty param in repeat expr) - rust-lang#78428 (MinConstGenerics UI test for invalid values for bool & char) - rust-lang#78460 (Adjust turbofish help message for const generics) - rust-lang#78470 (Clean up intra-doc links in `std::path`) - rust-lang#78475 (fix a comment in validity check) - rust-lang#78478 (Add const generics tests for supertraits + dyn traits.) - rust-lang#78487 (Fix typo "compiltest") - rust-lang#78491 (Inline NonZeroN::from(n)) - rust-lang#78492 (Update books) - rust-lang#78494 (Fix typos) Failed merges: r? `@ghost`
      
        
      
      
  
    16 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-const-generics
  Area: const generics (parameters and arguments) 
  
    A-testsuite
  Area: The testsuite used to check the correctness of rustc 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Partially addresses #78433