Skip to content

Conversation

tgnottingham
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2020
@tgnottingham
Copy link
Contributor Author

r? @Aaron1011

@rust-highfive rust-highfive assigned Aaron1011 and unassigned estebank Oct 26, 2020
@tgnottingham
Copy link
Contributor Author

This admittedly doesn't improve performance much, but it still seems sensible to avoid the unnecessary work.

@Aaron1011
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Oct 26, 2020

⌛ Trying commit a3623e0 with merge c78e1a98403d935f0d0ab399b69944da91214f16...

@bors
Copy link
Collaborator

bors commented Oct 26, 2020

☀️ Try build successful - checks-actions
Build commit: c78e1a98403d935f0d0ab399b69944da91214f16 (c78e1a98403d935f0d0ab399b69944da91214f16)

@rust-timer
Copy link
Collaborator

Queued c78e1a98403d935f0d0ab399b69944da91214f16 with parent 0da6d42, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (c78e1a98403d935f0d0ab399b69944da91214f16): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Aaron1011
Copy link
Contributor

@bors r+ rollup-

@bors
Copy link
Collaborator

bors commented Oct 27, 2020

📌 Commit a3623e0 has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2020
@bors
Copy link
Collaborator

bors commented Oct 28, 2020

⌛ Testing commit a3623e0 with merge 31ee872...

@bors
Copy link
Collaborator

bors commented Oct 28, 2020

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 31ee872 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2020
@bors bors merged commit 31ee872 into rust-lang:master Oct 28, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 28, 2020
@tgnottingham tgnottingham deleted the expn_id_tag_hash branch October 30, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants