Rollup of 10 pull requests #77860

JohnTitor · 2020-10-12T17:27:11Z

Successful merges:

Mark repr128 as incomplete_features #77488 (Mark repr128 as incomplete_features)
add shims for WithOptConstParam query calls #77550 (add shims for WithOptConstParam query calls)
Add word wrap for short descriptions #77699 (Add word wrap for short descriptions)
Implement AsRawFd for StdinLock etc. on WASI. #77724 (Implement AsRawFd for StdinLock etc. on WASI.)
Fix x.py setup sets changelog-seen #77746 (Fix x.py setup sets changelog-seen)
Fix intra-docs link in core::ffi::VaList #77784 (Fix intra-docs link in core::ffi::VaList)
rustdoc: Make some functions private that don't need to be public #77811 (rustdoc: Make some functions private that don't need to be public)
Mono collector: replace pair of ints with Range #77818 (Mono collector: replace pair of ints with Range)
Use std methods on char instead of open coding them #77831 (Use std methods on char instead of open coding them)
update url in bootstrap README (gcc-rs -> cc-rs) #77852 (update url in bootstrap README (gcc-rs -> cc-rs))

Failed merges:

WASI implements `AsRawFd` for `Stdin`, `Stdout`, and `Stderr`, so implement it for `StdinLock`, `StdoutLock`, and `StderrLock` as well.

More print statementsstatements lol Solved the basic case of eliminating check_version ifk_version if subcommand = setup Finished v1 checking out old bootstrap.py checked out old irrelevant files fixed tidy Moved VERSION from bin/main.rs to lib.rs Fixed semicolon return issue x.py fmt

… r=jonas-schievink Mark `repr128` as `incomplete_features` As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it. Closes rust-lang#77457.

@ecstatic-morse

…atic-morse add shims for WithOptConstParam query calls r? @ecstatic-morse @eddyb

@WaffleLapkin

Add word wrap for short descriptions Fixes rust-lang#77652 ![Screenshot from 2020-10-08 13-26-18](https://user-images.githubusercontent.com/3050060/95452770-11845280-096a-11eb-80da-723da85261fa.png) cc @WaffleLapkin r? @jyn514

@alexcrichton

…excrichton Implement `AsRawFd` for `StdinLock` etc. on WASI. WASI implements `AsRawFd` for `Stdin`, `Stdout`, and `Stderr`, so implement it for `StdinLock`, `StdoutLock`, and `StderrLock` as well. r? @alexcrichton

Fix `x.py setup` sets `changelog-seen` Fixes rust-lang#77572 by setting changelog-seen in setup.rs

…a-docs, r=jyn514 Fix intra-docs link in core::ffi::VaList At some point, `VaList` was changes to be a [wrapper](https://github.com/rust-lang/rust/blob/1661f77/library/core/src/ffi.rs#L177-L201) over `VaListImpl`, and now the `Arg` method exists on [`VaListImpl`](https://github.com/rust-lang/rust/blob/1661f77/library/core/src/ffi.rs#L333-L336). This PR fixes the intradoc links so that when `--document-private-items` is ran on std (via [patch](https://gist.github.com/aDotInTheVoid/42c82306210203f9c9093c952b765ab4)), it works

@GuillaumeGomez

rustdoc: Make some functions private that don't need to be public r? @GuillaumeGomez

Mono collector: replace pair of ints with Range I found the initial PR (rust-lang#33171) that introduced this piece of code but I didn't find any information about why a tuple was preferred over a `Range<usize>`. I'm hoping there are no technical reasons to not do this.

Use std methods on char instead of open coding them

…-schievink update url in bootstrap README (gcc-rs -> cc-rs) gcc-rs is renamed to cc-rs 3 years ago.

JohnTitor · 2020-10-12T17:27:31Z

@bors r+ rollup=never p=5
@rustbot modify labels: rollup

bors · 2020-10-12T17:27:32Z

📌 Commit 206fc76 has been approved by JohnTitor

bors · 2020-10-12T17:42:22Z

⌛ Testing commit 206fc76 with merge 20cde220a60ac547d1d4fea9bdf4c1bc047bc5ca...

bors · 2020-10-12T18:09:01Z

💔 Test failed - checks-actions

JohnTitor · 2020-10-12T18:16:25Z

Mark isn't a maintainer of the rustc-dev-guide anymore and it causes failure: https://github.com/rust-lang-ci/rust/runs/1243600577

Build completed successfully in 0:02:16
+ /scripts/validate-toolstate.sh
Cloning into 'rust-toolstate'...
<Nothing changed>
error: rustc-dev-guide maintainer @mark-i-m is not assignable in the rust-lang/rust repo

  To be assignable, a person needs to be explicitly listed as a
  collaborator in the repository settings. The simple way to
  fix this is to ask someone with 'admin' privileges on the repo
  to add the person or whole team as a collaborator with 'read'
  privileges. Those privileges don't grant any extra permissions
  so it's safe to apply them.

The build will fail due to this.

The fix for it is #77863.

varkor and others added 23 commits October 3, 2020 14:47

Mark repr128 as incomplete_features

db0438b

cleanup WithOptConstParam queries

536674f

query_name_of_opt_const_arg -> query_name_opt_const_arg

8160bfa

Remove unused class rule

ce45b4f

Implement AsRawFd for StdinLock etc. on WASI.

8d2c622

WASI implements `AsRawFd` for `Stdin`, `Stdout`, and `Stderr`, so implement it for `StdinLock`, `StdoutLock`, and `StderrLock` as well.

Fix intra-docs link

d5b7143

Use range instead of tuple of ints

0a2a68e

Make some functions private that don't need to be public

83c790f

Don't duplicate char::is_ascii_digit

e533bb7

Simplify using is_ascii_alphabetic and is_ascii_alphanumeric

a56b0e9

update url in bootstrap README

5d44402

Add word-wrap rule for short descriptions

9f1048d

Rollup merge of rust-lang#77550 - lcnr:ty-dep-path-ct-cleanup, r=ecst…

287b950

…atic-morse add shims for WithOptConstParam query calls r? @ecstatic-morse @eddyb

Rollup merge of rust-lang#77746 - winnayx:issue-77572-fix, r=jyn514

ce0fa67

Fix `x.py setup` sets `changelog-seen` Fixes rust-lang#77572 by setting changelog-seen in setup.rs

Rollup merge of rust-lang#77811 - jyn514:private, r=GuillaumeGomez

7f4b363

rustdoc: Make some functions private that don't need to be public r? @GuillaumeGomez

Rollup merge of rust-lang#77831 - LingMan:use_std, r=jonas-schievink

58542c2

Use std methods on char instead of open coding them

Rollup merge of rust-lang#77852 - 12101111:fix-bootstrap-doc, r=jonas…

206fc76

…-schievink update url in bootstrap README (gcc-rs -> cc-rs) gcc-rs is renamed to cc-rs 3 years ago.

rustbot added the rollup A PR which is a rollup label Oct 12, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2020

JohnTitor closed this Oct 12, 2020

JohnTitor deleted the rollup-jdp1jpb branch October 12, 2020 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #77860

Rollup of 10 pull requests #77860

Uh oh!

JohnTitor commented Oct 12, 2020

Uh oh!

JohnTitor commented Oct 12, 2020

Uh oh!

bors commented Oct 12, 2020

Uh oh!

bors commented Oct 12, 2020

Uh oh!

bors commented Oct 12, 2020

Uh oh!

JohnTitor commented Oct 12, 2020 •

edited

Loading

Uh oh!

Uh oh!

Rollup of 10 pull requests #77860

Rollup of 10 pull requests #77860

Uh oh!

Conversation

JohnTitor commented Oct 12, 2020

Uh oh!

JohnTitor commented Oct 12, 2020

Uh oh!

bors commented Oct 12, 2020

Uh oh!

bors commented Oct 12, 2020

Uh oh!

bors commented Oct 12, 2020

Uh oh!

JohnTitor commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JohnTitor commented Oct 12, 2020 •

edited

Loading