BTreeMap: keep an eye out on the size of the main components #77233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
|
||
| #[test] | ||
| fn test_sizes() { | ||
| #[cfg(all(any(target_os = "windows", target_os = "unix"), target_pointer_width = "32"))] |
There was a problem hiding this comment.
We should be able to get away with just #[cfg(target_arch = "x86_64)] and a single pair of asserts, I think -- that's what we do in rustc and it works well.
There was a problem hiding this comment.
Yeah, that seems wiser. I actually wondered what the effect is of the two u16 fields in LeafNode that are combined - if it helps to give them each 32 bits on 64 bit platforms. But testing that doesn't have to remain in there.
ssomers
force-pushed
the
btree_size_matters
branch
from
d8eb0a5 to
646f0ad
Compare
jyn514
added
the
T-libs
ssomers
force-pushed
the
btree_size_matters
branch
from
646f0ad to
3e485d7
Compare
|
@bors r+ rollup |
|
📌 Commit 3e485d7 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 30, 2020
…Simulacrum BTreeMap: keep an eye out on the size of the main components r? @Mark-Simulacrum
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2020
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#77037 (more tiny clippy cleanups) - rust-lang#77233 (BTreeMap: keep an eye out on the size of the main components) - rust-lang#77280 (Ensure that all LLVM components requested by tests are available on CI) - rust-lang#77284 (library: Forward compiler-builtins "mem" feature) - rust-lang#77296 (liveness: Use Option::None to represent absent live nodes) - rust-lang#77322 (Add unstable book docs for `-Zunsound-mir-opts`) - rust-lang#77328 (Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn()) - rust-lang#77331 (Add test for async/await combined with const-generics.) - rust-lang#77338 (Fix typo in alloc vec comment) - rust-lang#77340 (Alloc vec use imported path) - rust-lang#77345 (Add test for issue rust-lang#74761) - rust-lang#77348 (Update books) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Mark-Simulacrum