Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 19, 2020

closes #66075, we now have no remaining uses of match_def_path in the compiler while some uses still remain in clippy.

cc @RalfJung

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2020
@RalfJung
Copy link
Member

closes #66075, we now have no remaining uses of match_def_path in the compiler while some uses still remain in clippy.

Cool! However, this does not close #66075 as that one is also about making Rc and Arc not be lang items any more.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 19, 2020

Rc and Arc are already only diagnostic_items, it seems like this has already been fixed

@lcnr lcnr force-pushed the foreign-item-like branch from 16db762 to a4a9e2e Compare September 19, 2020 09:26
@lcnr lcnr force-pushed the foreign-item-like branch from a4a9e2e to 0eecbd4 Compare September 19, 2020 09:33
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2020
@jyn514 jyn514 added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 19, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Sep 19, 2020

@bors r+

r? @oli-obk

@bors
Copy link
Collaborator

bors commented Sep 19, 2020

📌 Commit bfa2030 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned estebank Sep 19, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
transmute: use diagnostic item

closes rust-lang#66075, we now have no remaining uses of `match_def_path`  in the compiler while some uses still remain in `clippy`.

cc @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
Rollup of 15 pull requests

Successful merges:

 - rust-lang#76732 (Add docs for `BasicBlock`)
 - rust-lang#76832 (Let backends define custom targets)
 - rust-lang#76866 (Remove unused feature gates from library/ crates)
 - rust-lang#76875 (Move to intra-doc links in library/alloc/src/collections/binary_heap.rs)
 - rust-lang#76876 (Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs)
 - rust-lang#76877 (Move to intra-doc links in collections/vec_deque.rs and collections/vec_deque/drain.rs)
 - rust-lang#76878 (Move the version number to a plaintext file)
 - rust-lang#76883 (README.md: Remove prompts from code blocks)
 - rust-lang#76887 (Add missing examples on HashSet iter types)
 - rust-lang#76890 (use matches!() macro for simple if let conditions)
 - rust-lang#76891 (don't take `TyCtxt` by reference)
 - rust-lang#76910 (transmute: use diagnostic item)
 - rust-lang#76924 (Add tracking issue for feature(unix_socket_peek))
 - rust-lang#76926 (BTreeMap: code readability tweaks)
 - rust-lang#76940 (Don't allow implementing trait directly on type-alias-impl-trait)

Failed merges:

r? `@ghost`
@bors bors merged commit 7ff17c1 into rust-lang:master Sep 20, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete move to "diagnostic items"
8 participants