Skip to content

Conversation

camelid
Copy link
Member

@camelid camelid commented Sep 14, 2020

@rustbot modify labels: T-doc T-compiler

Also improve the docs for it a bit.
@rustbot rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Sep 14, 2020
@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2020
@camelid
Copy link
Member Author

camelid commented Sep 14, 2020

5c1043a is probably best reviewed in side-by-side mode :)

@camelid camelid changed the title Use intra-doc links for DelaySpanBugEmitted Small docs improvements Sep 14, 2020
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 14, 2020
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 14, 2020

📌 Commit 5c1043a has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2020
Comment on lines +2288 to +2289
/// this does not necessarily mean that they are `==` in Rust -- in
/// particular, one must be wary of `NaN`!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better?

Suggested change
/// this does not necessarily mean that they are `==` in Rust -- in
/// particular, one must be wary of `NaN`!
/// this does not necessarily mean that they are `==` in Rust. In
/// particular, one must be wary of `NaN`!

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 16, 2020
Small docs improvements

@rustbot modify labels: T-doc T-compiler
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#76669 (Prefer asm! over llvm_asm! in core)
 - rust-lang#76675 (Small improvements to asm documentation)
 - rust-lang#76681 (remove orphaned files)
 - rust-lang#76694 (Introduce a PartitioningCx struct)
 - rust-lang#76695 (fix syntax error in suggesting generic constraint in trait parameter)
 - rust-lang#76699 (improve const infer error)
 - rust-lang#76707 (Simplify iter flatten struct doc)
 - rust-lang#76710 (:arrow_up: rust-analyzer)
 - rust-lang#76714 (Small docs improvements)
 - rust-lang#76717 (Fix generating rustc docs with non-default lib directory.)

Failed merges:

r? `@ghost`
@bors bors merged commit b25261f into rust-lang:master Sep 16, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 16, 2020
@camelid camelid deleted the patch-3 branch September 16, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants