Upgrade to pulldown-cmark 0.8.0 #76689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to marcusklaas' hard work in pulldown-cmark/pulldown-cmark#469, this fixes a lot of rustdoc bugs! - Get rid of unnecessary `RefCell` - Fix duplicate warnings for broken implicit reference link - Remove unnecessary copy of links
jyn514
added
T-rustdoc
|
Do you want to add "Closes #76687" to your PR message and then I'll open a new issue for smart punctuation? |
|
Good idea, done |
|
It looks like rust-highfive didn't work. r? @euclio |
|
Hmm, perhaps it's offline? |
|
@camelid euclio isn't an org member, so highfive crashes. |
jyn514
added
the
S-waiting-on-review
|
Huh, interesting. I thought I've seen it assign non-org members before, but maybe that was a manual assignment... |
camelid
reviewed
Sep 14, 2020
This shows the span of the _whole_ link, including the brackets. But rustdoc only wants to warn about the link text.
jyn514
force-pushed
the
update-pulldown
branch
from
e031c94 to
6f2e1c6
Compare
|
@camelid it does for issues via triagebot or has to "delegated" |
GuillaumeGomez
approved these changes
Sep 14, 2020
|
This is so great! :D @bors: r+ |
|
📌 Commit 6f2e1c6 has been approved by |
bors
added
S-waiting-on-bors
I reverted this back to using |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#73955 (deny(unsafe_op_in_unsafe_fn) in libstd/process.rs) - rust-lang#75146 (Detect overflow in proc_macro_server subspan) - rust-lang#75304 (Note when a a move/borrow error is caused by a deref coercion) - rust-lang#75749 (Consolidate some duplicate code in the sys modules.) - rust-lang#75882 (Use translated variable for test string) - rust-lang#75886 (Test that bounds checks are elided for [..index] after .position()) - rust-lang#76048 (Initial support for riscv32gc_unknown_linux_gnu) - rust-lang#76198 (Make some Ordering methods const) - rust-lang#76689 (Upgrade to pulldown-cmark 0.8.0) - rust-lang#76763 (Update cargo) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to marcusklaas' hard work in pulldown-cmark/pulldown-cmark#469, this fixes a lot of rustdoc bugs!
RefCellCloses #73264, closes #76687.
r? @euclio
I'm not sure if the switch away from
locatefixes any open bugs - euclio mentioned some in pulldown-cmark/pulldown-cmark#165, but I didn't see any related issues open for rustdoc. Let me know if I missed one.