- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          rustbuild: Build tests with LLD if use-lld = true was passed
          #76378
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| (rust_highfive has picked a reviewer for you, use r? to override) | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
dc1963d    to
    7717876      
    Compare
  
    c53e0f3    to
    b27fca7      
    Compare
  
    | Could you also update this line? Line 432 in 35fc835 
 | 
| 
 Done. | 
| @bors r+ | 
| 📌 Commit 75a2c68 has been approved by  | 
| The job  Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact  | 
| ☀️ Test successful - checks-actions, checks-azure | 
Addresses #76127 (comment).
Our test suite is generally ready to run with an explicitly specified linker (#45191),
so LLD specified with
use-lld = trueworks as well.Only 4 tests fail (on
x86_64-pc-windows-msvc):All of them are legitimate issues with LLD (or at least with combination Rust+LLD) and manifest in segfaults on access to TLS (#76127 (comment)). UPD: These issues are caused by #72145 and appear because I had
-Ctarget-cpu=nativeset.UPD: Further commits build tests with LLD for non-MSVC targets and propagate LLD to more places when
use-lldis enabled.