Address review comments about config.toml from rustc-dev-guide PR #76141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This info was lost in rust-lang#74334.
jyn514
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
jyn514
added a commit
to jyn514/rustc-dev-guide
that referenced
this pull request
Aug 31, 2020
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also rust-lang#795 (comment).
|
I also added a comment about the defaults for |
jyn514
changed the title
verbose-tests
jyn514
added a commit
to jyn514/rustc-dev-guide
that referenced
this pull request
Aug 31, 2020
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also rust-lang#795 (comment).
tshepang
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 31, 2020
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also #795 (comment).
eddyb
reviewed
Aug 31, 2020
eddyb
reviewed
Aug 31, 2020
eddyb
reviewed
Aug 31, 2020
- Use prettier syntax for codegen-units defaults - Remove comment about parallelism that only made sense for specific values of codegen-units - Be more specific about what `verbose-tests` does
ehuss
reviewed
Sep 1, 2020
|
@bors r+ rollup |
|
📌 Commit ba664c2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#75094 (Add `-Z combine_cgu` flag) - rust-lang#75984 (Improve unresolved use error message) - rust-lang#76141 (Address review comments about config.toml from rustc-dev-guide PR) - rust-lang#76313 (Improved the MIR spanview output) - rust-lang#76430 (Add align to rustc-attrs unstable book) - rust-lang#76465 (Add a script to automatically update Rust/Clang versions in documentation) - rust-lang#76473 (Add missed spaces to GCC-WARNING.txt) - rust-lang#76481 (Convert repetitive target_pointer_width checks to const solution.) - rust-lang#76493 (Remove a stray ignore-tidy-undocumented-unsafe) - rust-lang#76504 (Capitalize safety comments) - rust-lang#76515 (SessionDiagnostic: Fix non-determinism in generated format string.) - rust-lang#76516 (Enable GitHub Releases synchronization) - rust-lang#76522 (remove redundant clones) - rust-lang#76523 (Remove unused PlaceContext::NonUse(NonUseContext::Coverage)) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This info was lost in #74334. See also rust-lang/rustc-dev-guide#795 (review).
r? @Mark-Simulacrum or @eddyb