- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Use assertions on Vec doc #76058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Use assertions on Vec doc #76058
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Clarify what the state of Vec after with_capacity on doc.
              
                    jyn514
  
              
              reviewed
              
                  
                    Aug 29, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after nit fixed
Co-authored-by: Joshua Nelson <[email protected]>
| @bors r+ rollup @jyn514 note to self - follow up on #76058 (comment) | 
| 📌 Commit 2d1ab83 has been approved by  | 
    
  matklad 
      added a commit
        to matklad/rust
      that referenced
      this pull request
    
      Aug 31, 2020 
    
    
      
  
    
      
    
  
Use assertions on Vec doc Clarify what the state of Vec after with_capacity on doc. r? @jyn514
  This was referenced Aug 31, 2020 
      
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Aug 31, 2020 
    
    
      
  
    
      
    
  
Rollup of 9 pull requests Successful merges: - rust-lang#75969 (Switch to intra-doc links in core/src/{convert,iter}/mod.rs) - rust-lang#76023 (Liballoc extend use intra doc link) - rust-lang#76033 (Add missing hyphen) - rust-lang#76052 (rust-langGH-66816: Remove disable attr before return) - rust-lang#76055 (Keep doc standard for Vec DrainFilter) - rust-lang#76058 (Use assertions on Vec doc) - rust-lang#76069 (Use explicit intra-doc link in path for Vec resize) - rust-lang#76117 (Update README.md) - rust-lang#76134 (Update MinGW instructions to include ninja) Failed merges: r? @ghost
    
  matklad 
      added a commit
        to matklad/rust
      that referenced
      this pull request
    
      Sep 4, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
    
  matklad 
      added a commit
        to matklad/rust
      that referenced
      this pull request
    
      Sep 4, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
    
  matklad 
      added a commit
        to matklad/rust
      that referenced
      this pull request
    
      Sep 4, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
    
  matklad 
      added a commit
        to matklad/rust
      that referenced
      this pull request
    
      Sep 4, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
    
  matklad 
      added a commit
        to matklad/rust
      that referenced
      this pull request
    
      Sep 4, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
    
  Dylan-DPC-zz 
      pushed a commit
        to Dylan-DPC-zz/rust
      that referenced
      this pull request
    
      Sep 6, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
    
  Dylan-DPC-zz 
      pushed a commit
        to Dylan-DPC-zz/rust
      that referenced
      this pull request
    
      Sep 6, 2020 
    
    
      
  
    
      
    
  
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-docs
  Area: Documentation for any part of the project, including the compiler, standard library, and tools 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Clarify what the state of Vec after with_capacity on doc.
r? @jyn514