Skip to content

Conversation

pickfire
Copy link
Contributor

push_all_move is the same as extend

push_all_move is the same as extend
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@matklad
Copy link
Contributor

matklad commented Aug 20, 2020

do we want to rename the other push_all to extend_from_slice?

@pickfire
Copy link
Contributor Author

@matklad Nice idea, added.

@matklad
Copy link
Contributor

matklad commented Aug 20, 2020

Note sure if this is exactly in my jurisdiction, but the changes seem fine to me, so

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 20, 2020

📌 Commit 4f2e182 has been approved by matklad

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#75672 (Move to intra-doc links for task.rs and vec.rs)
 - rust-lang#75702 (Clean up E0759 explanation)
 - rust-lang#75703 (Enable stack-overflow detection on musl for non-main threads)
 - rust-lang#75710 (Fix bad printing of const-eval queries)
 - rust-lang#75716 (Upgrade Emscripten on CI to 1.39.20 )
 - rust-lang#75731 (Suppress ty::Float in MIR comments of ty::Const)
 - rust-lang#75733 (Remove duplicated alloc vec bench push_all_move)
 - rust-lang#75743 (Rename rustc_lexer::TokenKind::Not to Bang)

Failed merges:

r? @ghost
@bors bors merged commit 6ac1523 into rust-lang:master Aug 20, 2020
@pickfire pickfire deleted the patch-3 branch August 21, 2020 07:11
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants