Skip to content

Conversation

mati865
Copy link
Member

@mati865 mati865 commented Aug 16, 2020

When calling rust-lld directly it accepts only --out-implib {} or --out-implib={} not --out-implib,{}.

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Aug 17, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 17, 2020

📌 Commit 1627ba1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2020
Rollup of 3 pull requests

Successful merges:

 - rust-lang#75548 (librustc_metadata::locator: Properly detect file type.)
 - rust-lang#75603 (Use more compatible out-implib style)
 - rust-lang#75637 (update stacker to 0.1.11 to unbreak build for wasm32-unknown-unknown)

Failed merges:

r? @ghost
@bors bors merged commit d70ae9b into rust-lang:master Aug 18, 2020
@mati865 mati865 deleted the mingw-out-implib-compat branch August 18, 2020 06:05
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants