merge as_local_hir_id with local_def_id_to_hir_id
#75448
Merged
+241
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in intra-doc-links. cc @jyn514 |
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
davidtwco
approved these changes
Aug 12, 2020
src/test/ui/__check/what.rs
Outdated
| @@ -0,0 +1,11 @@ | |||
| // check-pass | |||
|
@bors r+ |
|
📌 Commit ffda53f has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Aug 13, 2020
merge `as_local_hir_id` with `local_def_id_to_hir_id` `as_local_hir_id` was defined as just calling `local_def_id_to_hir_id` and I think that having two different ways to call the same method is somewhat confusing. Don't really care about which of these 2 methods we want to keep. Does this require an MCP, considering that these methods are fairly frequently used?
|
@bors r- I didn't intend to add this test here, will remove it 😅 |
bors
added
S-waiting-on-author
lcnr
force-pushed
the
rn-as_local_hir_id
branch
from
ffda53f to
4769db0
Compare
lcnr
force-pushed
the
rn-as_local_hir_id
branch
from
4769db0 to
cd53760
Compare
|
ok, should be fixed |
davidtwco
approved these changes
Aug 13, 2020
|
@bors r=davidtwco |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
|
📌 Commit cd53760 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#75376 (Set CMAKE_SYSTEM_NAME when cross-compiling) - rust-lang#75448 (merge `as_local_hir_id` with `local_def_id_to_hir_id`) - rust-lang#75513 (Recover gracefully from `struct` parse errors) - rust-lang#75545 (std/sys/unix/time: make it easier for LLVM to optimize `Instant` subtraction.) Failed merges: - rust-lang#75514 (Replaced `log` with `tracing`) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_local_hir_idwas defined as just callinglocal_def_id_to_hir_idand I think that having two different ways to call the same method is somewhat confusing.Don't really care about which of these 2 methods we want to keep.
Does this require an MCP, considering that these methods are fairly frequently used?