Remove unsused NodeId related APIs in hir map
#72996
Merged
+8
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup We should probably try to merge #72552 now, right? I think it will just be a few lines, and going from two hash table lookups to one shouldn't be controversial. Removing the table entirely by changing the |
|
📌 Commit d0fccb5 has been approved by |
bors
added
S-waiting-on-bors
|
@ecstatic-morse i'll rebase #72552 once this has landed 👍 |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 5, 2020
…pis, r=ecstatic-morse Remove unsused `NodeId` related APIs in hir map cc rust-lang#50928 r? @ecstatic-morse
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 5, 2020
…pis, r=ecstatic-morse Remove unsused `NodeId` related APIs in hir map cc rust-lang#50928 r? @ecstatic-morse
This was referenced Jun 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72260 (Spell out `Self` in async function return) - rust-lang#72996 (Remove unsused `NodeId` related APIs in hir map) - rust-lang#73010 (Update RELEASES.md) - rust-lang#73017 (Use assert_eq for liballoc test) - rust-lang#73019 (add test for rust-lang#72960) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #50928
r? @ecstatic-morse